Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test / example of using rootpath on a run_binary directory output #862

Merged
merged 1 commit into from
Jun 5, 2024
Merged

test: add test / example of using rootpath on a run_binary directory output #862

merged 1 commit into from
Jun 5, 2024
+16 −1

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jun 5, 2024 •
edited
Loading

In support of a Bazel Slack question on location of run_binary out_dirs: https://bazelbuild.slack.com/archives/C04281DTLH0/p1717607601723849?thread_ts=1717158361.547679&cid=C04281DTLH0.

Changes are visible to end-users: no

Test plan

  • New test cases added

@gregmagolan gregmagolan requested a review from jbedard June 5, 2024 17:34
@gregmagolan gregmagolan changed the title test: add test / example of using root path on a run_binary directory output test: add test / example of using rootpath on a run_binary directory output Jun 5, 2024
@gregmagolan gregmagolan enabled auto-merge (squash) June 5, 2024 17:34
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jun 5, 2024 •
edited
Loading

Test

5 test targets passed

Targets 
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild] 83ms
//lib/tests/jq:check_stamped [k8-fastbuild]                  359ms
//lib/tests/run_binary:dir_a_rootpath_test [k8-fastbuild]    220ms
//lib/tests/run_binary:dir_test [k8-fastbuild]               58ms
//lib/tests/yq:check_stamped [k8-fastbuild]                  101ms

Total test execution time was 821ms. 211 tests (97.7%) were fully cached saving 43s.

Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.

Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 423ms.

Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Buildifier      Format      Gazelle

@gregmagolan gregmagolan merged commit 00310a5 into main Jun 5, 2024
37 checks passed
@gregmagolan gregmagolan deleted the out_dirs_rootpath_test branch June 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard